search

aurelia / cli

The Aurelia 1 command line tool. Use the CLI to create projects, scaffold components, and bundle your app for release.
MIT License
407 stars 133 forks source link

feat: switch from libsass to dart-sass #1171

Closed 3cp closed 4 years ago

3cp commented 4 years ago

Because dart-sass is now the reference implementation of sass.

3cp commented 4 years ago

All protractor docker images failed with strange error. Once again, I cannot reproduce the failure locally. @shahabganji any idea what's going on?

shahabganji commented 4 years ago

I will check them.

Am 03.04.2020 um 10:26 schrieb Chunpeng Huo notifications@github.com:

 All protractor docker images failed with strange error. Once again, I cannot reproduce the failure locally. @shahabganji any idea what's going on?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

shahabganji commented 4 years ago

@3cp

it looks that outDir worked on two configurations, 2nd & 3rd, what is wrong with the other one? did you change anything there? it sounds that e2e tests failed now!

3cp commented 4 years ago

No idea. I am doing local test.

shahabganji commented 4 years ago

okay, let me check that too on Travis.

3cp commented 4 years ago

The whole dotnet app is messed up. The compiled code is wrong.

3cp commented 4 years ago

Once I remove the "outDir": "", it comes back to normal. 😭

3cp commented 4 years ago

I will try noEmit.

3cp commented 4 years ago

No, cannot use noEmit, tsc doesn't emit any output. Cannot use "outDir":"" either, it changes tsc output file path (even in gulp vinyl file).

Both are dangerous options.

shahabganji commented 4 years ago

@3cp all green! gulp-dart-sass?

3cp commented 4 years ago

Yep, using previously failed commit. The travis win10 box failed to install nodejs v10.12, I am gonna ignore that error.