search

aurelia / framework

The Aurelia 1 framework entry point, bringing together all the required sub-modules of Aurelia.
MIT License
11.75k stars 623 forks source link

fix(786) documentation says export instead of exports #787

Closed Anthony-Mckale closed 7 years ago

Anthony-Mckale commented 7 years ago

I'm submitting a bug fix

Current behavior:

http://aurelia.io/hub.html#/doc/article/aurelia/framework/latest/bundling-jspm/9

{ "name":"jquery", "path":"../node_modules/jquery/dist", "main":"jquery.min", "export": "$" } is incorrect

Expected/desired behavior:

{ "name":"jquery", "path":"../node_modules/jquery/dist", "main":"jquery.min", "exports": "$" } as per http://requirejs.org/docs/api.html

What is the motivation / use case for changing the behavior? avoid confusion for folks using old libraries

Anthony-Mckale commented 7 years ago

786 fix for this ticket

EisenbergEffect commented 7 years ago

@JeroenVinke Can you confirm whether this change is correct or not?

JeroenVinke commented 7 years ago

Yep, looks good! I actually didn't notice this PR and made one myself for exactly the same: https://github.com/aurelia/framework/pull/816. That one i've closed so we can merge this