search

aurelia / ux

A user experience framework with higher-level capabilities, designed to bring simplicity and elegance to building cross-device, rich experiences.
MIT License
368 stars 55 forks source link

fix(publish): update peer dependencies before publish #301

Closed MaximBalaganskiy closed 4 years ago

MaximBalaganskiy commented 4 years ago

Lerna ignores peerDependencies completely whilst they need to be in line with devDependencies.

Also, add missing modules to components

bigopon commented 4 years ago

@EisenbergEffect at the moment, dependencies are specified as peer deps. This is to combat an issue where users would have duplicated version of a modules. Though this makes lerna skip updating dependencies of packages, as it ignore peers section.

Do you see any issues with hooking into prepublishOnly? Description:

prepublishOnly: Run BEFORE the package is prepared and packed, ONLY on npm publish. (See below.)

EisenbergEffect commented 4 years ago

No objections from me.

bigopon commented 4 years ago

@MaximBalaganskiy is there any other hook that let us have "what you see in git is what you get in npm"? As I understand that this will modify package.json, but won't create a commit for git.

MaximBalaganskiy commented 4 years ago

version hook suits better - it's run right before the commit

bigopon commented 4 years ago

The description of version commands from https://docs.npmjs.com/misc/scripts. If we want t enhance this more, maybe use some more from lerna and https://docs.npmjs.com/cli/version.html

preversion: Run BEFORE bumping the package version.
version: Run AFTER bumping the package version, but BEFORE commit.
postversion: Run AFTER bumping the package version, and AFTER commit.

Looks suitable for this to me. Thanks @MaximBalaganskiy