search

aureliojargas / sedsed

Debugger and code formatter for sed scripts
https://aurelio.net/projects/sedsed/
GNU General Public License v3.0
115 stars 10 forks source link

add --sedbin to specify alternative sed executable #73

Closed clarkwang closed 3 years ago

clarkwang commented 4 years ago

For https://github.com/aureliojargas/sedsed/issues/72

aureliojargas commented 3 years ago

Hi @clarkwang, thank you very much for your contribution, I think --sedbin will be a nice improvement.

Could you please remove the -E commit from this PR, so this one stay focused in the --sedbin part?

clarkwang commented 3 years ago

I don't know how. I made the -E change after sending the first pull request. I don't understand why it include both commits here.

clarkwang commented 3 years ago

You can go ahead and get the diff and apply on your repo. It's ok for me.

clarkwang commented 3 years ago

Will create a feature branch for --sedbin and make a new pull request. Closing this confusing one.

aureliojargas commented 3 years ago

Superseded by #75

Thanks @clarkwang for taking care of this.