auth0-samples / auth0-xamarin-oidc-samples

Auth0 OIDC Client with Xamarin applications
MIT License
29 stars 38 forks source link

Bumped Auth0.OidcClient.Android to 3.1.3 #35

Closed stevehobbsdev closed 4 years ago

stevehobbsdev commented 4 years ago

Description

This PR bumped Auth0.OidcClient.Android to 3.1.3 to gain access to a fix for passwordless flows, where the user would not be in the same state after closing their app to go and get the access code from another app.

Type of change

Testing

Tested manually in the emulator using a passwordless flow, by verifying the issue then upgrading the library.

Additional info

stevehobbsdev commented 4 years ago

@lbalmaceda No, have verified no breaking changes.

lbalmaceda commented 4 years ago

@stevehobbsdev what about this change https://auth0.github.io/auth0-oidc-client-net/documentation/migration/v3.html#android

stevehobbsdev commented 4 years ago

I can update it to include that, but the way it's worded doesn't sound like a breaking change to me.

Let me raise a PR.

lbalmaceda commented 4 years ago

Yes. It's not a breaking change. If I remember correctly, it's fixing the "minimize to reach the MFA code and resume" case. It would be a good addition.

stevehobbsdev commented 4 years ago

https://github.com/auth0-samples/auth0-xamarin-oidc-samples/pull/36