Make KeyProvider interface public

auth0 / java-jwt

Java implementation of JSON Web Token (JWT)

MIT License

5.84k stars 921 forks source link

Make KeyProvider interface public #653

Closed vladertel closed 1 year ago

vladertel commented 1 year ago

Changes

Make KeyProvider interface public

Sometimes it's handy to return KeyProvider in some user code.

Checklist

[x] I have read the Auth0 general contribution guidelines
[x] I have read the Auth0 Code of Conduct
[ ] All existing and new tests complete without errors

jimmyjames commented 1 year ago

👋 hey @vladertel can you provide some context/use-case for making it public? Understanding that can help us understand if this is a type we should expose. Thanks!

jimmyjames commented 1 year ago

I'm going to close this PR due to lack of activity.

We are open to making the KeyProvider public, but as it expands the public API surface area we need to understand the specific use-cases it would enable to determine if it's the right thing. If you would like to open a new issue outlining the use-cases that would be addressed by making it public, along with current workarounds or alternatives, that will help us make a determination. Thanks!