[IAMRISK-3553] Swapped CAPTCHA on each reload

Treterten commented 6 months ago

Changes

Updates swap code so that CAPTCHA gets swapped along with the form

References

Testing

This can be tested via layer0 by pulling down the changes and running through the instructions under DEVELOPMENT.md for Testing Lock locally through the Universal Login Page

[ ] This change adds unit test coverage N/A
[ ] This change adds integration test coverage N/A
[x] This change has been tested on the latest version of the platform/language

Checklist

[x] I have read the Auth0 general contribution guidelines
[x] I have read the Auth0 Code of Conduct
[x] All code quality tools/guidelines have been run/followed
[x] All relevant assets have been compiled

Video of Fix

https://github.com/auth0/lock/assets/60672637/c89164f3-9def-4d31-ba12-bc774b07e7d4

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 42.13%. Comparing base (a847c14) to head (42e455e). Report is 10 commits behind head on master.

:exclamation: Current head 42e455e differs from pull request most recent head 326dc51

Please upload reports for the commit 326dc51 to get more accurate results.

Files	Patch %	Lines
src/connection/database/actions.js	0.00%	11 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #2558 +/- ## ========================================== - Coverage 42.35% 42.13% -0.22% ========================================== Files 120 120 Lines 3081 3116 +35 Branches 335 335 ========================================== + Hits 1305 1313 +8 - Misses 1682 1710 +28 + Partials 94 93 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nandan-bhat commented 6 months ago

Hi @Treterten,

Can you add some tests for the changes made ? codecov checks aren't passing.

nandan-bhat commented 6 months ago

Closing this pull request because another pull request containing the same changes has been merged into the master branch.

auth0 / lock