search

auto-complete / popup-el

Visual Popup Interface Library for Emacs
GNU General Public License v3.0
445 stars 96 forks source link

Add popup-isearch-yank. #108

Closed kostafey closed 8 years ago

kostafey commented 8 years ago

Add popup-isearch-yank.

kostafey commented 8 years ago

Looks like test environment problem. Is it possible to fix?

syohex commented 8 years ago

Is it possible to fix?

Yes, it is newer Cask issue. I'll fix it later.

syohex commented 8 years ago

Thanks PR. I have cherry-picked your commit and fixed CI issue. However I use only C-y key binding because C-v is not emacs like key binding.

kostafey commented 8 years ago

Why not C-v? There is no conflict here. Users can use both. One likes C-y, other prefer cua-mode and C-v. Ok, it's possible to add it to popup-isearch-keymap in custom's .emacs but I can't see any reason to avoid it by default.

syohex commented 8 years ago

I want to save key bindings as possible in the future and it is enough to assign one key binding.