search

auto-complete / popup-el

Visual Popup Interface Library for Emacs
GNU General Public License v3.0
445 stars 96 forks source link

perf(popup.el): enable lexical binding #139

Closed LemonBreezes closed 12 months ago

LemonBreezes commented 12 months ago

Upon inspecting the code, I do not see anything can present a problem with enabling lexical-binding. One day Emacs will enable lexical binding by default so it's better merge this earlier to reduce the risk of a mass config breakage event.

jcs090218 commented 12 months ago

Sounds good to me. Is there a reason this is still draft? 🤔

LemonBreezes commented 12 months ago

Oh, I was going to review the writing more but it's ok!

jcs090218 commented 12 months ago

Oh, I was going to review the writing more but it's ok!

No worries. I can wait until this is ready! Just let me know when it's ready to merge! :)

LemonBreezes commented 12 months ago

Oh, I was going to review the writing more but it's ok!

No worries. I can wait until this is ready! Just let me know when it's ready to merge! :)

I just force-pushed and it closed the PR. Is it possible to re-open this one? EDIT: I think I somehow messed up the fork.