autolab-project / autolab

Python package for laboratory instruments control and scientific experiments automation
https://autolab.readthedocs.io/
GNU General Public License v3.0
28 stars 7 forks source link

[issue] Devices not closing when closing GUI #4

Closed pyMatJ closed 2 years ago

pyMatJ commented 2 years ago

After discussing w/ @bgarbin I will open a few issues and feature requests, and start to work on PRs. Starting with this one, even though I see this appears somehow in the todolist ("autolab.close_all_devices()") : When using the GUI and closing, the close() function of each driver should be called before the GUI actually closes, ensuring that all devices are returned to a safe state and all connection ports are available again.

EDIT: This issue is already solved by PR https://github.com/qcha41/autolab/pull/3 (specifically commit https://github.com/qcha41/autolab/pull/3/commits/06237e4725507ee09de39e1147055648d0939185 ) If this PR contains too many changes at once, consider doing a separate one for this issue.