search

automerge / automerge-repo-rs

MIT License
39 stars 6 forks source link

Remove unnecessary trait bound #32

Closed teohhanhui closed 1 year ago

teohhanhui commented 1 year ago

Allow using tokio::net::unix::SocketAddr which does not implement tokio::net::ToSocketAddrs

gterzian commented 1 year ago

LGTM, especially since we don't do anything with the source as it stands. @alexjg ?

alexjg commented 1 year ago

I would go further and remove the source parameter

teohhanhui commented 1 year ago

I think that has value for tracing, no?

alexjg commented 1 year ago

True but we're not actually using it at the moment. Either way, I'll merge this for now.