search

automl / ParameterImportance

Parameter Importance Analysis Tool
http://www.ml4aad.org/
BSD 3-Clause "New" or "Revised" License
76 stars 19 forks source link

SMAC class name in latest version #112

Closed ndangtt closed 4 years ago

ndangtt commented 4 years ago

Hello,

I saw that current PIMP source code has the same issue as mentioned here, and thought that I should mention that to you!

These are the line with the issue: https://github.com/automl/ParameterImportance/blob/45e776f987147368cefba86bc685d949a2938060/pimp/pimp.py#L15 https://github.com/automl/ParameterImportance/blob/45e776f987147368cefba86bc685d949a2938060/pimp/pimp.py#L34

Best regards, Nguyen

AndreBiedenkapp commented 4 years ago

Oh thank you very much for reporting the issue. That was unfortunately overlooked.

ndangtt commented 4 years ago

You're very welcome! Thank you for looking at it so quickly! :)

Nguyen

shukon commented 4 years ago

Sorry, lost this in my stack. Fixed in #113 and will be released asap.