search

automl / ParameterImportance

Parameter Importance Analysis Tool
http://www.ml4aad.org/
BSD 3-Clause "New" or "Revised" License
76 stars 19 forks source link

Compatibility with smac 0.12.0 #117

Closed shukon closed 4 years ago

shukon commented 4 years ago

Fixes #116

shukon commented 4 years ago

@AndreBiedenkapp Ah, sorry, forgot to change the title. Will work with Drafts from now on.

Specifically are the type casts necessary?

Well, SMAC 0.12.0 returns lists for that function now (not np.array's). After I was halfway through PIMP, porting everything that uses types to support lists instead of arrays, I realized that PIMP heavily relies on it being arrays to perform array-operations in multiple places (the link is one example). So if we have to cast anyway, we might as well do it consistently I figured. Are you ok with that?