autonomys-ambassadors / ambassador-os-peer-review

Automation for Ambassador OS Peer Review Process
Apache License 2.0
1 stars 1 forks source link

wrong branch commit #12

Closed mathematicw closed 1 month ago

mathematicw commented 1 month ago

Changes: ✔️ Added the Max 6-Month PP column to track the maximum penalty points within any 6-month period across all months. ✔️ Implemented processing for past months to calculate missed submission events per ambassador (runs once and logs status in script properties). ✔️ Integrated the cleaning cache (refreshing state) function into the onOpen menu. ✔️ Reminders now sent to evaluators who missed at least one submitter. ✔️ Calculated the date of the previous month, adjusting for the Pacific Time Zone. ✔️ Added annotations in dedicated columns of the month-sheet (with comfort coloring). ✔️ If new review matrix is created and a month sheet already exists, the "Final Score" column is cleared. ✔️ Sorted the "submitters" column in the month-sheet alphabetically. ✔️ Implemented exemption notifications for evaluators not assigned any submitters. ✔️ Timing and ordering issues: Functions in a script behave differently when run sequentially through a custom menu versus one-by-one in the script editor, this is due to timing and ordering issues in Google Apps Script. This badly affected functions in module 3. The most reliable way to handle this is to call the next function at the end of each function, unless it’s already logically triggered. However, using SpreadsheetApp.flush(); to commit changes is also a workable solution. Testing with flush, and if issues arise, continuous chain of function calls should be applied ✔️ Renamed ambassadors' emails issue when sending expulsion notification. ✔️ 7 day passed after RoE: If user choose Cancel - script goes off. If Yes - continue. ✔️ Improved menu ✔️The calculatePenaltyPointsForSubmissions function now skips ambassadors if their email is not found, continuing to the next ambassador (for testing purposes, when amb is expelled). ✔️ Expelled ambassadors are now applied special tag to both Email and Discord handle. And so they will be available in Overall score (if reference columns) ✔️Caching Issues: Running module 3 functions directly works well, but using them from the menu accessed outdated cached data. Adjustments in SharedUtilities now reinitialize color and critical variables in each function to prevent caching issues. This issue occurs when multiple projects are present, though it can still be useful in cases of repeated variable changes. ✔️ A warning and 1-run limitation has been added for past month processing, as this function adds penalty points incrementally; changing a property flag allows re-runs. Future upcoming: Prefilled Evaluation forms URLs