autopkg / keeleysam-recipes

Recipes for autopkg!
Apache License 2.0
21 stars 49 forks source link

Error in CarbonCopyCloner download #158

Open robertryansqub opened 1 year ago

robertryansqub commented 1 year ago

In the last few days I've started to see this error when running the CarbonCopyCloner recipe:

% autopkg run -vv local.munki.CarbonCopyCloner                        
Processing local.munki.CarbonCopyCloner...
URLTextSearcher
{'Input': {'re_pattern': '(/software/download_ccc\\.php\\?v=latest.*)\\"',
           'result_output_var_name': 'match',
           'url': 'https://bombich.scdn1.secure.raxcdn.com/download'}}
URLTextSearcher: Found matching text (match): /software/download_ccc.php?v=latest"><i class="fa fa-cloud-download
{'Output': {'match': '/software/download_ccc.php?v=latest"><i class="fa '
                     'fa-cloud-download'}}
URLDownloader
{'Input': {'filename': 'CarbonCopyCloner.zip',
           'url': 'https://bombich.scdn1.secure.raxcdn.com/software/download_ccc.php?v=latest"><i '
                  'class="fa fa-cloud-download'}}
URLDownloader: No value supplied for prefetch_filename, setting default value of: False
URLDownloader: No value supplied for CHECK_FILESIZE_ONLY, setting default value of: False
URLDownloader: ERROR: (3) URL using bad/illegal format or missing URL

curl: (3) URL using bad/illegal format or missing URL

Failed.
Receipt written to /Users/munki/Library/AutoPkg/Cache/local.munki.CarbonCopyCloner/receipts/local.munki-receipt-20230502-114620.plist

The following recipes failed:
    local.munki.CarbonCopyCloner
        Error in local.munki.CarbonCopyCloner: Processor: URLDownloader: Error: curl: (3) URL using bad/illegal format or missing URL

Nothing downloaded, packaged or imported.

This is with Autopkg 2.7.2 on macOS 13.3.1.

DoubleNaught7 commented 1 year ago

I'm seeing the same thing.

robertryansqub commented 1 year ago

Changing the regex in the .download recipe works, though I'm not sure how stable that will be long-term. I swapped it to:

<string>(/software/download_ccc\.php\?v=%VERSION%)\"</string>

macmangr commented 1 year ago

or:

<string>(/software/download_ccc\.php\?v=%VERSION%*)\"</string>