search

autopkg / precursorca-recipes

Recipes for AutoPkg
1 stars 7 forks source link

Update Webex Teams.download.recipe #4

Open poundbangbash opened 3 years ago

poundbangbash commented 3 years ago

Webex Teams rebranded to just be named Webex. This update reflects that change in the download recipe.

For those that already use Webex Teams they will need to deal with the application name change on the client in a way they see fit. I'm adding a postinstall_script to rm -r /Applications/Webex\ Teams.app.

image

precursorca commented 3 years ago

I created a brand new recipe for "Webex" to replace the defunct Webex Teams (which replace the defunct Cisco Spark). Users may utilize your "postinstall_script to rm -r /Applications/Webex\ Teams.app at their discretion.

grahampugh commented 3 years ago

@precursorca I notice that in your new Webex recipe, you switched from CFBundleShortVersionString to CFBundleVersion. Unfortunately this messes up versioning in Jamf which expects the CFBundleShortVersionString. Would you be willing to switch it back, or else allow it to be overridden?

precursorca commented 3 years ago

When they changed the product name from Webex Teams to Webex I just used Recipe Robot to build the new recipe. I seems that the decision over CFBundle is a difference in the way Recipe Robot 1.0.5 ( Webex Teams recipe) and Recipe Robot 2.0.0 ( Webex recipe) works.

I don’t really understand how it arrived at that but you might ask Elliot Jordan.

I don’t have Jamf Pro to test, just munki.

I suppose I could create an alternate recipe e.g. precursorca-recipes/Cisco/Webex.download.jamf.recipe Would that help?

Did you want to make a pull request? Or did you want me to try to make a new recipe for jamf donwloading?

Alex Narvey anarvey@precursor.ca

On Feb 22, 2021, at 3:44 AM, Graham Pugh notifications@github.com wrote:

@precursorca I notice that in your new Webex recipe, you switched from CFBundleShortVersionString to CFBundleVersion. Unfortunately this messes up versioning in Jamf which expects the CFBundleShortVersionString. Would you be willing to switch it back, or else allow it to be overridden?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

grahampugh commented 3 years ago

Hi Alex,

An alternative recipe won't be necessary. Jamf recipes (.jss or .jamf) use standard .pkg/.download recipes as their parents. If you are not fixed to the version string being used, I'll submit a PR. But I'll clarify with @homebysix right here :)

@homebysix Recipe Robot decided to grab the CFBundleVersion when creating the Webex.download recipe we are discussing here. Can you think of a reason why it didn't choose the standard CFBundleShortVersionString?

Cheers for your input Graham