search

autowarefoundation / autoware.universe

https://autowarefoundation.github.io/autoware.universe/
Apache License 2.0
1.03k stars 655 forks source link

feat(goal_planner): remove unnecessary member from ThreadSafeData #9393

Closed soblin closed 1 week ago

soblin commented 1 week ago

Description

remove static_target_objects and dynamic_target_objects from ThreadSafeData because there is no need to share

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

github-actions[bot] commented 1 week ago

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Project coverage is 29.92%. Comparing base (be8235d) to head (1bfbd19). Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...th_goal_planner_module/src/goal_planner_module.cpp 0.00% 19 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #9393 +/- ## ========================================== - Coverage 29.94% 29.92% -0.02% ========================================== Files 1338 1343 +5 Lines 103359 103428 +69 Branches 40236 40242 +6 ========================================== Hits 30951 30951 - Misses 69405 69472 +67 - Partials 3003 3005 +2 ``` | [Flag](https://app.codecov.io/gh/autowarefoundation/autoware.universe/pull/9393/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | Coverage Δ | | *Carryforward flag | |---|---|---|---| | [differential](https://app.codecov.io/gh/autowarefoundation/autoware.universe/pull/9393/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | `0.52% <0.00%> (?)` | | | | [total](https://app.codecov.io/gh/autowarefoundation/autoware.universe/pull/9393/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | `29.94% <ø> (+<0.01%)` | :arrow_up: | Carriedforward from [be8235d](https://app.codecov.io/gh/autowarefoundation/autoware.universe/commit/be8235d785597c41d01782ec35da862ba0906578?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features: