search

autowarefoundation / autoware.universe

https://autowarefoundation.github.io/autoware.universe/
Apache License 2.0
1.03k stars 655 forks source link

fix(autoware_freespace_planning_algorithms): fix clang-diagnostic-ignored-optimization-argument #9418

Closed kobayu858 closed 1 week ago

kobayu858 commented 1 week ago

Description

This is a fix based on clang-tidy clang-diagnostic-ignored-optimization-argument error.

error: optimization flag '-fno-fat-lto-objects' is not supported [clang-diagnostic-ignored-optimization-argument]

The fno-fat-lto-objects option is exclusive to GCC and cannot be used in Clang.

$ clang++ -### -fno-fat-lto-objects
Ubuntu clang version 14.0.0-1ubuntu1.1
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin
clang: warning: argument unused during compilation: '-fno-fat-lto-objects' [-Wunused-command-line-argument]

Therefore, it was explicitly indicated not to be used in the Makefile. There is no change in build time.

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

github-actions[bot] commented 1 week ago

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 29.93%. Comparing base (e901751) to head (462b73d). Report is 26 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #9418 +/- ## ========================================== - Coverage 29.94% 29.93% -0.02% ========================================== Files 1338 1344 +6 Lines 103359 103402 +43 Branches 40236 40237 +1 ========================================== Hits 30954 30954 - Misses 69405 69448 +43 Partials 3000 3000 ``` | [Flag](https://app.codecov.io/gh/autowarefoundation/autoware.universe/pull/9418/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | Coverage Δ | | *Carryforward flag | |---|---|---|---| | [differential](https://app.codecov.io/gh/autowarefoundation/autoware.universe/pull/9418/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | `22.55% <ø> (?)` | | | | [total](https://app.codecov.io/gh/autowarefoundation/autoware.universe/pull/9418/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | `29.94% <ø> (ø)` | | Carriedforward from [e901751](https://app.codecov.io/gh/autowarefoundation/autoware.universe/commit/e9017515ab29571e772b160316ddd259a237353e?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features: