search

autowarefoundation / autoware.universe

https://autowarefoundation.github.io/autoware.universe/
Apache License 2.0
1.03k stars 655 forks source link

feat(behavior_velocity_planner)!: remove stop_reason #9452

Open soblin opened 4 days ago

soblin commented 4 days ago

Description

StopReason interface will be deprecated, so remove it from behavior_velocity_planner

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

~/behavior_velocity/***/stop_reason disappears

Effects on system behavior

None.

github-actions[bot] commented 4 days ago

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

codecov[bot] commented 4 days ago

Codecov Report

Attention: Patch coverage is 10.25641% with 35 lines in your changes missing coverage. Please review.

Project coverage is 29.01%. Comparing base (b782772) to head (72730cf). Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
..._behavior_velocity_blind_spot_module/src/scene.cpp 0.00% 7 Missing :warning:
...ior_velocity_no_drivable_lane_module/src/scene.cpp 0.00% 7 Missing :warning:
...elocity_virtual_traffic_light_module/src/scene.cpp 0.00% 6 Missing :warning:
...ity_intersection_module/src/scene_intersection.cpp 0.00% 4 Missing :warning:
..._velocity_crosswalk_module/src/scene_crosswalk.cpp 0.00% 2 Missing :warning:
...havior_velocity_traffic_light_module/src/scene.cpp 0.00% 2 Missing :warning:
...ction_module/src/scene_merge_from_private_road.cpp 0.00% 1 Missing :warning:
...topping_area_module/src/scene_no_stopping_area.cpp 0.00% 1 Missing :warning:
..._behavior_velocity_speed_bump_module/src/scene.cpp 0.00% 1 Missing :warning:
...e_behavior_velocity_stop_line_module/src/scene.cpp 0.00% 1 Missing :warning:
... and 3 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #9452 +/- ## ========================================== - Coverage 29.04% 29.01% -0.03% ========================================== Files 1438 1444 +6 Lines 108452 108340 -112 Branches 41521 41416 -105 ========================================== - Hits 31496 31440 -56 + Misses 73917 73857 -60 - Partials 3039 3043 +4 ``` | [Flag](https://app.codecov.io/gh/autowarefoundation/autoware.universe/pull/9452/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | Coverage Δ | | *Carryforward flag | |---|---|---|---| | [differential](https://app.codecov.io/gh/autowarefoundation/autoware.universe/pull/9452/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | `22.63% <10.25%> (?)` | | | | [total](https://app.codecov.io/gh/autowarefoundation/autoware.universe/pull/9452/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | `29.04% <ø> (-0.01%)` | :arrow_down: | Carriedforward from [b782772](https://app.codecov.io/gh/autowarefoundation/autoware.universe/commit/b782772ee0ab506b309002e4a49bc8acd3da9bb8?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features: