autowarefoundation / autoware.universe

https://autowarefoundation.github.io/autoware.universe/
Apache License 2.0
1.03k stars 655 forks source link

fix(autoware_bytetrack): fix clang-diagnostic-implicit-const-int-float-conversion #9468

Open kobayu858 opened 3 days ago

kobayu858 commented 3 days ago

Description

This is a fix based on clang-tidy clang-diagnostic-implicit-const-int-float-conversion error.

/home/emb4/autoware/autoware/src/universe/autoware.universe/perception/autoware_bytetrack/lib/include/byte_tracker.h:86:77: error: implicit conversion from 'long' to 'float' changes value from 9223372036854775807 to 9223372036854775808 [clang-diagnostic-implicit-const-int-float-conversion]
    std::vector<int> & colsol, bool extend_cost = false, float cost_limit = LONG_MAX,
                                                                          ~ ^

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

github-actions[bot] commented 3 days ago

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

codecov[bot] commented 3 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 29.27%. Comparing base (b3ded07) to head (0c1cdb4). Report is 52 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #9468 +/- ## ========================================== - Coverage 29.27% 29.27% -0.01% ========================================== Files 1441 1441 Lines 108616 108617 +1 Branches 41571 41582 +11 ========================================== Hits 31794 31794 - Misses 73663 73740 +77 + Partials 3159 3083 -76 ``` | [Flag](https://app.codecov.io/gh/autowarefoundation/autoware.universe/pull/9468/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | Coverage Δ | | *Carryforward flag | |---|---|---|---| | [differential](https://app.codecov.io/gh/autowarefoundation/autoware.universe/pull/9468/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | `0.00% <ø> (?)` | | | | [total](https://app.codecov.io/gh/autowarefoundation/autoware.universe/pull/9468/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | `29.27% <ø> (-0.01%)` | :arrow_down: | Carriedforward from [19364ff](https://app.codecov.io/gh/autowarefoundation/autoware.universe/commit/19364ff11980e4e390dc429ac944cb1a2590cf58?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kobayu858 commented 16 hours ago

@manato @YoshiRi Please confirm the PR. Thank you very much.