search

autumnai / leaf

Open Machine Intelligence Framework for Hackers. (GPU/CPU)
Apache License 2.0
5.56k stars 270 forks source link

style/travis: Allow travis to build on container based system #47

Closed dirvine closed 8 years ago

dirvine commented 8 years ago

Added required apt-packages Added ability to run clippy as feature in nightly set sudo false in travis

Several remaining compile fixes remain, but will be resolved with upcoming fix with 0.2 code.

GitCop commented 8 years ago

There were the following issues with your Pull Request

Guidelines are available at https://github.com/autumnai/leaf/blob/develop/CONTRIBUTING.md#git-commit-guidelines

This message was auto-generated by https://gitcop.com

dirvine commented 8 years ago

Is it possible to have some examples of the commit message format? I see you use "style/XXX" where XX is changed file or module. I am not sure if this is what is missing, sorry for any miscommunication here. I Will also dig more into gitcop to see what I can find.

This PR will not pass tests until the 0.2 code commit lands AFAIK.

hobofan commented 8 years ago

I see you have figured it out, but you are right, having an example in the guidelines would certainly be nice (issue #48).

Since I saw that #46 passed with the other changes I will go ahead and merge it even though it's failing.

Thanks you! :)

hobofan commented 8 years ago

Oh :open_mouth:, only the PR title had the correct format, not the commit. Oh well...

dirvine commented 8 years ago

Ah yes I spotted that just after the merge. Oh well not to worry. Sorry chap, I ended up rebasing (hard) locally and could not get back to the commit. At least I now know. Next time though it will all be good.

hobofan commented 8 years ago

Yup, better luck next time :)