`NodeInitializer` requires a specific ServiceID pattern, which means users need to know about it and also conform to that pattern

ava-labs / avalanchego-kurtosis

Run AvalancheGo tests in the Kurtosis framework

BSD 3-Clause "New" or "Revised" License

3 stars 8 forks source link

`NodeInitializer` requires a specific ServiceID pattern, which means users need to know about it and also conform to that pattern #6

Open mieubrisse opened 3 years ago

mieubrisse commented 3 years ago

The pattern is bootstrapNode-%i, 1-indexed. We could resolve this by having the NodeInitializer take in bootstrappers []*NodeAPIService instead, without needing to know anything about the ServiceIDs that identify them

otherview commented 3 years ago

Goot spot - sorted the pattern, it was a leftover thing. Now starts at 0.

To have a bootstrapNode-X running, a user must use a (s *Scenario) FiveNodeNetwork scenario. It's not something part of the NodeInitializer but a construct; a set of operations that enables to rapidly create a topology.