search

avajs / eslint-plugin-ava

ESLint rules for AVA
https://avajs.dev
MIT License
230 stars 49 forks source link

Assertion methods auto correction for `use-t-well` rule #277

Closed stroncium closed 4 years ago

stroncium commented 5 years ago

Fixes #244

Simple breadth-first early terminating Levenshtein distance auto correcter for assertion methods. Handles all samples from the issue and some more. (Some of earlier test cases have more suiting error messages and became fixable too.)

Fixes #187

Detects and fixes multiple skip and skip being not the last in chain.

NOTE: integration tests fail for some reason, but they fail even without this patch. :unicorn:

IssueHunt Summary ### Referenced issues This pull request has been submitted to: - [#244: Make `use-t-well` more auto-fixable](https://issuehunt.io/repos/49722492/issues/244) - [#187: Skipping assertions is changing in AVA 1.0](https://issuehunt.io/repos/49722492/issues/187) --- IssueHunt has been backed by the following sponsors. [Become a sponsor](https://issuehunt.io/membership/members)
stroncium commented 4 years ago

@sindresorhus Moved the correction code itself to micro-spelling-correcter(https://github.com/stroncium/micro-spelling-correcter) which packs it all together and provides simplest interface possible. No magic constants anymore.

NOTE: codecov fails for https://github.com/stroncium/micro-spelling-correcter for some reason atm, but coverage is 100%, will look into why it fails later.

sindresorhus commented 4 years ago

Looks good :)