search

avajs / eslint-plugin-ava

ESLint rules for AVA
https://avajs.dev
MIT License
230 stars 49 forks source link

Use suggestions API for `no-only-test` and `no-skip-test` #325

Closed edbrannin closed 3 years ago

edbrannin commented 3 years ago

Closes https://github.com/avajs/eslint-plugin-ava/pull/324 https://github.com/avajs/eslint-plugin-ava/issues/281#issuecomment-587137623

edbrannin commented 3 years ago

@sindresorhus Integration tests are failing in the same way as they did in #324. Was the build already broken?

sindresorhus commented 3 years ago

You need to update the rule docs and the readme.

edbrannin commented 3 years ago

Whoops, thanks! I'll fix.

...actually, I checked the eslint code rules, the only() two() that support the suggest: API don't say anything about that or autofix in the docs.

Should I just drop references to Fixable for these rules, or would you prefer some other language?

sindresorhus commented 3 years ago

Should I just drop references to Fixable for these rules, or would you prefer some other language?

Drop

edbrannin commented 3 years ago

Done

(oh yay, the integration test is working now too!)

edbrannin commented 3 years ago

Thanks!

If you don't mind my asking, any idea when this might be released? I'm very much looking forward to updating this plugin on my services.

sindresorhus commented 3 years ago

It was released half an hour ago.

edbrannin commented 3 years ago

Oh, double-thanks then! Keep up the good work!