WIP: Fix tests after calling fixture functions directly became an error\

avast / pytest-docker

Docker-based integration tests

MIT License

423 stars 71 forks source link

WIP: Fix tests after calling fixture functions directly became an error\ #34

Closed butla closed 4 years ago

butla commented 5 years ago

This is still work in progress, cause I only fixed one file. I'm not sure if I should carry on with this fix, though, cause the other broken file - test_docker_services.py has brittle, mock-ridden tests, which I would gladly replace with some functional tests that don't rely on mocking.

Luminaar commented 4 years ago

Hello @butla! I've taken over as a maintainer of this project. Since problem was resolved in another PR so I'm closing this. I you are still interested in improving tests, I'll be happy for any future PRs.

butla commented 4 years ago

Ok, roger that. I had some ideas in my personal backlog, but never got the time to implement them. And I probably won't have that time now, cause nowadays I'm just keeping Compose running in the background all the time instead of using pytest-docker to put it up and close it...