avellinwong01 / pe

0 stars 0 forks source link

Workout schedule does not reschedule overdue workouts that are scheduled today but already past the current time #9

Open avellinwong01 opened 2 years ago

avellinwong01 commented 2 years ago

image.png

App reschedules workouts that are scheduled for past days.

image.png

However, app does not reschedule workout that is scheduled today (12th Nov) but already past time (3.40am)

nus-se-bot commented 2 years ago

Team's Response

This is an implementation choice, of which can be read about in the DG. Rescheduling only takes place once the workout is overdue:

image.png

Reasoning: it is useful to know what workouts were scheduled in the day, when looking back to record workouts and calories burned using the add workout command.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: While I agree that to be able to track all workouts on a current day, we should not reschedule workouts that already happened as long as its on the same day. However, based on my understanding, a scheduled workout should be something that at this point in time, I schedule something in the future. If I want to add a past workout that happened earlier in the day to record workouts and calories burned, shouldn't it be done using the add workout command directly, rather than adding a scheduled workout?

Also, I believe that this definition of overdue workouts should be in the UG to inform the user of this expected behaviour.


:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: I believe this is quite confusing. Also not sure if this implementation choice is the best as while I understand the rationale for adding a workout that has already happened earlier in the day to track, it should be added using add workout rather than add schedule as schedule implies a future workout. Hence, I feel that anything that already happened in the past (even if on the same day) that is added using add schedule should be rescheduled.