avendesora / pythonbible

A python library for validating, parsing, normalizing scripture references and retrieving scripture texts (for open source and public domain versions)
https://docs.python.bible
MIT License
58 stars 11 forks source link

0.5.0 Release for counter functions #36

Closed avendesora closed 3 years ago

sourcery-ai[bot] commented 3 years ago

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.27%.

Quality metrics Before After Change
Complexity 11.38 🙂 11.38 🙂 0.00
Method Length 88.44 🙂 89.33 🙂 0.89 👎
Working memory 11.64 😞 11.78 😞 0.14 👎
Quality 51.36% 🙂 51.09% 🙂 -0.27% 👎
Other metrics Before After Change
Lines 294 299 5
Changed files Quality Before Quality After Quality Change
pythonbible/init.py 82.94% ⭐ 81.99% ⭐ -0.95% 👎
pythonbible/parser.py 51.11% 🙂 50.85% 🙂 -0.26% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
pythonbible/parser.py _process_sub_reference 14 🙂 229 ⛔ 14 😞 36.60% 😞 Try splitting into smaller methods. Extract out complex expressions
pythonbible/parser.py normalize_reference 18 🙂 190 😞 13 😞 37.56% 😞 Try splitting into smaller methods. Extract out complex expressions
pythonbible/parser.py _process_sub_references 10 🙂 104 🙂 13 😞 53.55% 🙂 Extract out complex expressions
pythonbible/parser.py _get_book_group_references 1 ⭐ 44 ⭐ 11 😞 74.56% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.