search

aviaviavi / toodles

Project management directly from the TODOs in your codebase
MIT License
966 stars 35 forks source link

support chinese #65

Open xiaoDC opened 5 years ago

xiaoDC commented 5 years ago

can you support chinese comment? tky

aviaviavi commented 5 years ago

Thanks for opening @xiaoDC. Do you mean supporting chinese flags for TODO, FIXME, etc? If so, you should be able to use the flags setting in your toodles.yaml config to set whatever flags you want. If this isn't what you meant, can you describe what you're wanting a little more? Maybe an example of what you'd like to be able to do would be helpful.

xiaoDC commented 5 years ago

I mean if i use // TODO(fri3nds|p1) 添加接口，toodles happen with error. So i wish you can support 添加接口

aviaviavi commented 5 years ago

Ok I see. I actually would have expected this to work, so looks like a bug. I'll have a chance to look into this soon.

aviaviavi commented 5 years ago

@xiaoDC can you paste in the error you're getting, and any OS details? I just tried doing this on mac and it actually seems to work fine for me. can't seem to reproduce.

Screen Shot 2019-07-11 at 3 26 34 PM

xiaoDC commented 5 years ago

I use docker run -it -v $(pwd):/repo -p 9001:9001 aviaviavi/toodles。And in my project, there are some comments which like// 新建cmd，the error is 

Running toodles for path: /repo
/repo/pkg/command/cmd.go: hGetContents: invalid argument (invalid byte sequence)
aviaviavi commented 5 years ago

I see, must be some other unicode issue. I'll look into it, thanks for getting back to me

Saeger commented 4 years ago

Something isn’t operating as UTF-8