search

avil13 / vue-sweetalert2

A convenient wrapper for sweetalert2.
https://avil13.github.io/vue-sweetalert2/
656 stars 75 forks source link

Modify the import for sweetalert to not import the style at the sametime #76

Closed vincentdh closed 5 years ago

vincentdh commented 5 years ago

As per the Sweetalert2 documentation, the file 'sweetalert2/dist/sweetalert2.js' must be imported instead of the 'sweetalert2' module to import the stylesheet separatly.
Importing the 'sweetalert2' module completely will also import stylesheet and it will not be possible to use custom style.

vincentdh commented 5 years ago

I will double check my code and do a new PR ...

avil13 commented 5 years ago

Thanks for PR

vincentdh commented 5 years ago

Thanks for PR

I'm happy to contribute. But wait for my PR to works before saying thanks! ;)

avil13 commented 5 years ago

I tried it locally, it seems to work. Is there something wrong?

vincentdh commented 5 years ago

I tried it locally, it seems to work. Is there something wrong?

It did not pass Travis. I didn't used my usual IDE and deleted the wrong import. New PR on the way ;) in 2-3 minutes

vincentdh commented 5 years ago

PR #77 pass the coverage this time ;) let discuss on the other PR if needed