search

avivbiton / BlizzardApiReader

.Net Core library to handle Blizzard public APIs
MIT License
35 stars 36 forks source link

Handling cached data discussion #29

Open avivbiton opened 5 years ago

avivbiton commented 5 years ago

I wanted to discuss if we should include a caching feature since some of the api requests provide static data. I was thinking making at an ApiConfiguration option and when it is set to true calling method a api request (e.g GetActAsync) will check if the data is cached and return it if it is, if not it will call the api and then cache the data.
This will only apply to static data that doesn't change very often (Like api requests about quests or crafting recipes)
Opinions?

linahanner commented 5 years ago

Sounds like a solid idea, fully onboard! 👍

avivbiton commented 5 years ago

Started some work on this, I was thinking something very simple just storing the static data in a dictionary or some sort and retrieving it when called. I don't want to use any caching third party libraries.
Still figuring out the details.

avivbiton commented 5 years ago

Will continue working on this soon. (Ignore close and re-open was a miss click)