avrs-admin
commented
2 years ago Joerg Wunsch
Well, I don't think programmers usually have multiple IDs. However, the avrdude.conf syntax (see config_gram.y) allows for a string_list in that place.
I guess we don't really need to care for more than one ID, but we need to take into account that pgm->id points to the list rather than the list's datum.
IMHO, the following patch ought to fix it as well, can you verify?
Index: jtag3.c
===================================================================
--- jtag3.c (revision 1448)
+++ jtag3.c (working copy)
@@ -867,7 +867,7 @@
/* XplainedMini boards do not need this, and early revisions had a
* firmware bug where they complained about it. */
if (pgm->flag & PGM_FL_IS_EDBG) {
- if (strcmp(pgm->id, "xplainedmini_updi") != 0) {
+ if (strcmp(ldata(lfirst(pgm->id)), "xplainedmini_updi") != 0) {
if (jtag3_edbg_prepare(pgm) < 0) {
return -1;
}
@@ -1581,7 +1581,7 @@
/* XplainedMini boards do not need this, and early revisions had a
* firmware bug where they complained about it. */
if (pgm->flag & PGM_FL_IS_EDBG) {
- if (strcmp(pgm->id, "xplainedmini_updi") != 0) {
+ if (strcmp(ldata(lfirst(pgm->id)), "xplainedmini_updi") != 0) {
jtag3_edbg_signoff(pgm);
}
}
mcuee
MCUdude
Fri 22 Feb 2019 04:55:14 PM UTC
Hi,
I had already posted to the mailing list, but didn't get a response, so I'll try here as well. This was what I posted to the mailing list: https://lists.nongnu.org/archive/html/avrdude-dev/2019-01/msg00005.html
I think the error is caused by the way the programmer ID is compared against "xplainedmini_updi". The attached patch seems to fix the issue. However, I don't quite understand why a programmer would need a list of IDs in the first place, so I'd appreciate it if some skeptical eyes looked over my patch.
Thanks, Sven
file #46335: patch
This issue was migrated from https://savannah.nongnu.org/patch/?9757