awalker89 / openxlsx

R package for .xlsx file reading and writing.
Other
364 stars 79 forks source link

Feat sep.names #480

Open iago-pssjd opened 5 years ago

iago-pssjd commented 5 years ago

Feature for read.xlsx: sep.names allows choose other separator than '.' for variable names with a blank inside

codecov[bot] commented 5 years ago

Codecov Report

Merging #480 into master will decrease coverage by 0.08%. The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #480      +/-   ##
==========================================
- Coverage   60.23%   60.14%   -0.09%     
==========================================
  Files          30       30              
  Lines        7142     7146       +4     
==========================================
- Hits         4302     4298       -4     
- Misses       2840     2848       +8
Impacted Files Coverage Δ
R/wrappers.R 42.61% <ø> (ø) :arrow_up:
src/openxlsx_init.c 0% <ø> (ø) :arrow_up:
src/read_workbook.cpp 90.61% <100%> (-0.33%) :arrow_down:
R/helperFunctions.R 75.56% <100%> (ø) :arrow_up:
R/workbook_read_workbook.R 88.88% <66.66%> (-0.38%) :arrow_down:
R/readWorkbook.R 82.94% <75%> (-0.15%) :arrow_down:
src/write_data.cpp 61.06% <0%> (-3.5%) :arrow_down:
src/write_file.cpp 88.57% <0%> (-0.09%) :arrow_down:
src/load_workbook.cpp 89.93% <0%> (-0.07%) :arrow_down:
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ead0038...168e4e8. Read the comment docs.

ycphs commented 4 years ago

I implemented your PR in my new fork of the repository https://github.com/ycphs/openxlsx

iago-pssjd commented 4 years ago

Thank you!