awendland / angular-json-tree

Angular directive for displaying a JSON object in an expandable tree structure
Other
79 stars 41 forks source link

startExpanded=True expands all nodes by default #56

Closed saetsac closed 5 years ago

saetsac commented 7 years ago

Change startExpanded behavior so we could expand all child nodes automatically

Description

Inherits startExpanded from parent element. Tracks element by $index (without it arrays were failing to expand)

Motivation and Context

startExpanded by expanding only the top element is kind of a strange thing. We need to expand everything at once.

How Has This Been Tested?

Unittests 4/4 pass

Types of changes

Checklist:

vinnyb0341 commented 7 years ago

is there any chance this pull request will be merged?

awendland commented 7 years ago

Apologies for the massive delays in reviewing these PRs, I will attempt to review this on the weekend. Thank you for the addition to the project!

vinnyb0341 commented 7 years ago

Don't mean to keep nagging on this, but is this getting reviewed soon?