Open champsupertramp opened 8 years ago
Hi @pippinsplugins,
I'd like to know why it checks for object arguments when this filter pre_set_site_transient_update_plugins returns array? http://hookr.io/filters/pre_set_site_transient_update_plugins/#usage
pre_set_site_transient_update_plugins
I found an issue where it swaps the existing passed array with an object that's why it always lookup for an update on every load of the /plugin.php page and disrespects the last_time expiration when checking in transient? https://github.com/easydigitaldownloads/EDD-License-handler/blob/master/EDD_SL_Plugin_Updater.php#L83
last_time
https://github.com/easydigitaldownloads/EDD-License-handler/blob/master/EDD_SL_Plugin_Updater.php#L138
Hi @pippinsplugins,
I'd like to know why it checks for object arguments when this filter
pre_set_site_transient_update_pluginsreturns array? http://hookr.io/filters/pre_set_site_transient_update_plugins/#usageI found an issue where it swaps the existing passed array with an object that's why it always lookup for an update on every load of the /plugin.php page and disrespects the
last_timeexpiration when checking in transient? https://github.com/easydigitaldownloads/EDD-License-handler/blob/master/EDD_SL_Plugin_Updater.php#L83https://github.com/easydigitaldownloads/EDD-License-handler/blob/master/EDD_SL_Plugin_Updater.php#L138