search

aws-amplify / amplify-hosting

AWS Amplify Hosting provides a Git-based workflow for deploying and hosting fullstack serverless web applications.
https://aws.amazon.com/amplify/hosting/
Apache License 2.0
450 stars 113 forks source link

Consider Making update-domain-association Less Destructive #482

Open jhoffmcd opened 4 years ago

jhoffmcd commented 4 years ago

Is your feature request related to a problem? Please describe.

It's hard to tell by the naming of this command that you can't just update one entry of the domain associations rules. If you only try to update the one association you want, you end up wiping out the other associations that exist for that project. This seems too aggressive for an update. And is not well documented enough to prevent unsuspecting users from potentially bringing down their prod site because they would wipe out that association with this command.

Describe the solution you'd like

Update update-domain-association to only update the --sub-domain-settings that are passed and preserve the existing associations not passed to the command.

At the very least, just update the documentation so that users know what kind of outcomes to expect from this command.

Additional context

https://github.com/aws-amplify/amplify-console/issues/196#issuecomment-548053431 https://docs.aws.amazon.com/cli/latest/reference/amplify/update-domain-association.html

nimacks commented 4 years ago

@jhoffmcd, your feedback is highly appreciated. We will look into this.

RavianXReaver commented 2 years ago

Is this currently being worked on? Because I can't seem to use create_domain_association as well.

mossymaker commented 3 months ago

not well documented enough to prevent unsuspecting users from potentially bringing down their prod site

✋ As an unsuspecting user, I can confirm that the docs are not clear even a little about being destructive. Managed to bring down production with this for a few panicked minutes.

With the current Amplify console heckery around domain configuration, I'd hoped update-domain-association would be reliable while that gets sorted out.

Are we to understand the process is to dump the current config, change the one subdomain, and push the whole config back up? 🤨