iartemiev
commented
2 years ago Hey @applyinnovations, DataStore only invokes the custom error handler when it encounters an AppSync mutation error. That's the current expected behavior. The custom error handler's purpose is to allow you to write business logic for handling various AppSync error scenarios and adjust the locally-persisted records accordingly.
For example:
- User creates a new record on a model where they don't have Create permissions
- DataStore does not enforce auth rules in the client, so it persists the data locally and sends a mutation request to AppSync
- AppSync rejects the mutation
- DataStore invokes custom error handler
- Error handler business logic tells DataStore to delete the record from the local store
For catching client-side errors - such as field validation - we recommend using try...catch blocks when calling DataStore.save and DataStore.delete.
applyinnovations
nubpro
chrisbonifacio
cfbo
Before opening, please confirm:
JavaScript Framework
React, React Native
Amplify APIs
DataStore
Amplify Categories
api
Environment information
Describe the bug
DataStore uses default errorHandler for some errors, and uses my custom error handler for other errors.
I have implemented a custom error handler by calling
DataStore.configurein my app entry point (App.tsx).When submitting a DataStore.save() with a model containing invalid data: Our AppSync API returns an error to the DataStore client and our custom error handler is used.
When submitting a DataStore.save() with an empty model: DataStore encounters the error
Error: Field name is requiredand uses the default error handler. Resulting in the following being logged to the console:[WARN] 38:37.438 DataStore - failed to execute errorHandler – Error: Field name is requiredExpected behavior
The expected behaviour is to catch/route all errors to my custom errorHandler
Reproduction steps
type Model { number: Int }DataStore.configure({ errorHandler: (error) => alert(Custom handler ${error.message}) });DataStore.save(new Model({ number: 1 }))-> no errorDataStore.save(new Model({ number: "not a number" }))-> custom error handlerDataStore.save(new Model({}))-> default error handlerCode Snippet
Log output
aws-exports.js
No response
Manual configuration
No response
Additional configuration
No response
Mobile Device
No response
Mobile Operating System
No response
Mobile Browser
No response
Mobile Browser Version
No response
Additional information and screenshots
No response