aws-amplify / amplify-studio

AWS Amplify Studio (Formerly Admin UI)
132 stars 31 forks source link

Figma Components Design #950

Closed shivennn closed 10 months ago

shivennn commented 10 months ago

Which Specific Feature is your question related to?

Figma Components

Question

Components in Figma before restructuring :

components-in-figma-file-before-change

The Figma variants are required to have the same component structure. If the variants don't have the same child elements, then Amplify Studio will not be able to import the component.

Components in Figma after restructuring :

components-in-figma-file-after-change

For two properties containing two variables (2, 2), you disintegrated all variants into different components. Changing it from 1 component to 4 components. What about a component with three properties having three variables (333=27components instead of 1 !). If such is the case, how to tackle such an explosive expansion on no of components. With limit of 1000 components, such explosive expansion on components would not let any reasonable website to viable.

Is there a better way where no of components are not disintegrated explosively?

Eumag commented 10 months ago

Thanks @shivennn for raising this issue.

I was able to resolve it by bringing some redundancy (sum union of all) in the composition to make the structure same and making the unnecessary children invisible (while taking care of layout). This does not increase the no of components and no explosive growth. This is important because total no of components allowed in AmplifyStudio is very limited.

Briefly speaking, if there is a parent component P and two child components C1 and C2 with composition C1.comp1 and C2.comp2. Then bring in the redundancy by including both comp1 and comp2 for C1 and C2 both. Make C1.comp2 and C2.comp1 as invisible.

This is illustrated further in the attached diagram.

Screenshot 2023-05-27 at 12 53 49 PM Screenshot 2023-05-27 at 12 52 53 PM
ykethan commented 10 months ago

closing due to inactivity. Please feel free in reaching out to us again.

github-actions[bot] commented 10 months ago

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see. If you need more assistance, please open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so.