aws-cloudformation / cfn-lint

CloudFormation Linter
MIT No Attribution
2.46k stars 597 forks source link

Support serverless v2 DBInstanceClass #2257

Closed fdansey-ostmodern closed 2 years ago

fdansey-ostmodern commented 2 years ago

cfn-lint version: 0.59.0

Allowed list of DBInstanceClass does not include "db.serverless"

Please provide as much information as possible:

Cfn-lint uses the CloudFormation Resource Specifications as the base to do validation. These files are included as part of the application version. Please update to the latest version of cfn-lint or update the spec files manually (cfn-lint -u)

PatMyron commented 2 years ago
  • this fixes it for me locally

surprised by that since we're pulling those lists from pricing and I don't see db.serverless in RDS' pricing file or being picked up by our automated cfn-lint -u runs: https://github.com/aws-cloudformation/cfn-lint/pull/2255

Locally, I still see db.serverless issues after running cfn-lint -u: E3025 DBInstanceClass "db.serverless" is not compatible with engine type "aurora-postgresql" and LicenseModel "general-public-license" in region "us-east-1". Use instance types [db.r4.16xlarge, db.r4.2xlarge, db.r4.4xlarge, db.r4.8xlarge, db.r4.large, db.r4.xlarge, db.r5.12xlarge, db.r5.16xlarge, db.r5.24xlarge, db.r5.2xlarge, db.r5.4xlarge, db.r5.8xlarge, db.r5.large, db.r5.xlarge, db.r6g.12xlarge, db.r6g.16xlarge, db.r6g.2xlarge, db.r6g.4xlarge, db.r6g.8xlarge, db.r6g.large, db.r6g.xlarge, db.t3.large, db.t3.medium, db.t4g.large, db.t4g.medium, db.x2g.12xlarge, db.x2g.16xlarge, db.x2g.2xlarge, db.x2g.4xlarge, db.x2g.8xlarge, db.x2g.large, db.x2g.xlarge]


Recommend working around with resource-level ignores since this doesn't look like a quick fix

k-mizutani-bns commented 2 years ago

https://aws.amazon.com/about-aws/whats-new/2022/10/amazon-aurora-serverless-v2-supports-aws-cloudformation/?nc1=h_ls

Amazon Aurora Serverless v2 supports AWS CloudFormation on Oct 5, 2022 . So I want to support it .

rishFilet commented 2 years ago

This issue needs to be reopened. I downloaded the latest update (0.68.1) and i am still seeing the error with the db.serverless not recognised as part of DBinstance

kddejong commented 2 years ago

Looking into it.

kddejong commented 2 years ago

Found the issue. Working on resolution.

kddejong commented 2 years ago

Try this again. Should be in the v0.69.0 release.