search

aws-controllers-k8s / community

AWS Controllers for Kubernetes (ACK) is a project enabling you to manage AWS services from Kubernetes
https://aws-controllers-k8s.github.io/community/
Apache License 2.0
2.39k stars 253 forks source link

Remove canary tests from applicationautoscaling-controller #859

Open jaypipes opened 3 years ago

jaypipes commented 3 years ago

The canary tests that were added to the applicationautoscaling-controller repository are specific to SageMaker and not the applicationautoscaling-controller codebase. They should be removed.

surajkota commented 3 years ago

application autoscaling needs a resource that can be registered for scaling. e2e tests use sagemaker endpoint as a scalable resource to test scalable target and scaling policy in this test. Similarly, there are other tests that use dynamodb as scalable resource

The PR that is originally listed in this issue is related to some helper scripts/configurations which help run e2e tests on released helm charts on an EKS cluster (i.e. canary)

can you provide more details on why these tests or scripts should be removed?

ack-bot commented 2 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close. Provide feedback via https://github.com/aws-controllers-k8s/community. /lifecycle stale

ack-bot commented 2 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with /close. Provide feedback via https://github.com/aws-controllers-k8s/community. /lifecycle rotten

a-hilaly commented 2 years ago

/remove-lifecycle stale

a-hilaly commented 2 years ago

/remove-lifecycle rotten

ack-bot commented 2 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close. Provide feedback via https://github.com/aws-controllers-k8s/community. /lifecycle stale

vijtrip2 commented 2 years ago

/lifecycle frozen