search

aws-ia / cfn-ecr-aws-soci-index-builder

Apache License 2.0
27 stars 12 forks source link

Service principal to use AWS::URLSuffix to work in all regions #34

Closed JohnPreston closed 1 year ago

JohnPreston commented 1 year ago

Proposed Changes

AWS Service principals "domains" should use AWS::URLSuffix for easy portability to different regions.

sparr commented 1 year ago

This translation is hard coded for China at https://github.com/aws-ia/cfn-ecr-aws-soci-index-builder/blob/main/functions/source/soci-index-generator-lambda/handler.go#L179-L186 which may deserve a better implementation as well.

JohnPreston commented 1 year ago

Does that mean no need for this, can close? Not that I'd need to use it nor that I have seen it supported, but wouldn't that work for us-gov regions too? Happy either way :)

sparr commented 1 year ago

No, I didn't mean to say this is not needed. This is a good PR. My observation was about another location that is currently more functional than what you're fixing, but is less functional than your fixed version, so it might need an update as well.

Kern-- commented 1 year ago

I don't think this change is needed. We have successfully tested this stack in both GovCloud and China. The lambda/events service principals do not need the URL suffix.

tbulding commented 1 year ago

Closing This PR