search

aws-ia / cfn-ecr-aws-soci-index-builder

Apache License 2.0
27 stars 12 forks source link

Updated runtime to provided.al2 #41

Closed sondavidb closed 1 year ago

sondavidb commented 1 year ago

Related Issue

39

Proposed Changes

As the go 1.x runtime is on track to be deprecated at the end of this year, we are switching to use the provided.al2 runtime instead. I tested via running the SOCI snapshotter via the SOCI index built both before and after the change and confirmed that they had identical outputs. Further testing should be done via various workloads to ensure there is no significant difference.

Reviewers

@turan18 or @Kern--

sondavidb commented 1 year ago

Just ran a test on Fargate and let it run for a few minutes after startup and ensured nothing crashed.

sondavidb commented 1 year ago

Did you verify that the new stack created a SOCI index for a newly pushed image? From the PR description I can't tell if you pushed a new image or if you expected the index to be regenerated.

I pushed a regular image to a test repo after creating the stack and the SOCI index was automatically built from it.

I would expect the mismatch between the Handler name and the executable name to cause problems, but confirmation would be good.

Per the AWS Compute blogpost I had to change the output to be called bootstrap. As it ran without issue it seems the discrepancy, while annoying, seems to be accepted by the system.