aws-observability / terraform-aws-observability-accelerator

Open source project to help accelerate and ease observability setup on AWS environments
https://aws-observability.github.io/terraform-aws-observability-accelerator/
Apache License 2.0
288 stars 84 forks source link

fix: eks 1.28 migrate kubectl provider to alekc repo #245

Closed rlanore closed 11 months ago

rlanore commented 11 months ago

What does this PR do?

Fix issue with gavinbunney/kubectl on eks 1.28. Some resource disappear or re-created on every tf apply

Migrate to alekc/kubectl providers

close #244

Motivation

Make it work on every tf apply with eks 1.28

More

For Moderators

Additional Notes

bonclay7 commented 11 months ago

Hey thanks for this PR!

rlanore commented 11 months ago

Hi, weird i had miss a commit. sorry LGTM now without tfsec

[] 🠶 pre-commit run -a
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check for merge conflicts................................................Passed
detect private key.......................................................Passed
detect aws credentials...................................................Passed
Terraform fmt............................................................Passed
Terraform docs...........................................................Passed
Terraform validate.......................................................Passed
Terraform validate with tflint...........................................Passed
Terraform validate with tfsec............................................Failed