Closed veerapratapg closed 2 months ago
Tagging reviewers --> @bonclay7 @lewinkedrs
Made the following changes to incorporate the suggestions from @lewinkedrs :
test
from the names of policy attachment resources. Made the changes suggested by @bonclay7 and removed managed_grafana_workspace_id
from the SSM parameter name created through external-secrets
to reduce the number of changes made.
This PR has been automatically marked as stale because it has been open 60 days with no activity. Remove stale label or comment or this PR will be closed in 10 days
Working on the incorporating unit tests for the Lambda function per my conversation with bonclay7@
Added Unit Tests for Lambda function in the grafana-key-rotation
module in the directory ./modules/grafana-key-rotation/tests/unit/src
. Also added a ReadMe file in the same location with a quick overview of steps to run the Tests.
This PR has been automatically marked as stale because it has been open 60 days with no activity. Remove stale label or comment or this PR will be closed in 10 days
Closing this PR as Managed Grafana v9 and 10 introduced Service account and service account token (SAT) APIs, instead of API Keys.
What does this PR do?
Motivation
More
pre-commit run -a
with this PRNote: Not all the PRs required examples and docs.
For Moderators
Additional Notes