aws-observability / terraform-aws-observability-accelerator

Open source project to help accelerate and ease observability setup on AWS environments
https://aws-observability.github.io/terraform-aws-observability-accelerator/
Apache License 2.0
288 stars 84 forks source link

API Key rotation for Grafana Workspace #259

Closed veerapratapg closed 2 months ago

veerapratapg commented 10 months ago

What does this PR do?

Motivation

More

Note: Not all the PRs required examples and docs.

For Moderators

Additional Notes

veerapratapg commented 10 months ago

Tagging reviewers --> @bonclay7 @lewinkedrs

veerapratapg commented 9 months ago

Made the following changes to incorporate the suggestions from @lewinkedrs :

  1. Added a README.md doc to grafana-key-rotation module with information regarding :
    • What the module does and the resources it creates
    • How to enable/disable it.
    • Some of the configuration options.
  2. Performed testing with the latest version of python runtime for Lambda, "3.12", and the solution is working as expected.
  3. Removed test from the names of policy attachment resources.
  4. Also removed white spaces from the mentioned files.
  5. Added variables for python runtime, event bridge scheduler expressions to provide additional flexibility for users.
veerapratapg commented 9 months ago

Made the changes suggested by @bonclay7 and removed managed_grafana_workspace_id from the SSM parameter name created through external-secrets to reduce the number of changes made.

github-actions[bot] commented 7 months ago

This PR has been automatically marked as stale because it has been open 60 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

veerapratapg commented 6 months ago

Working on the incorporating unit tests for the Lambda function per my conversation with bonclay7@

veerapratapg commented 5 months ago

Added Unit Tests for Lambda function in the grafana-key-rotation module in the directory ./modules/grafana-key-rotation/tests/unit/src. Also added a ReadMe file in the same location with a quick overview of steps to run the Tests.

github-actions[bot] commented 3 months ago

This PR has been automatically marked as stale because it has been open 60 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

veerapratapg commented 2 months ago

Closing this PR as Managed Grafana v9 and 10 introduced Service account and service account token (SAT) APIs, instead of API Keys.