aws-observability / terraform-aws-observability-accelerator

Open source project to help accelerate and ease observability setup on AWS environments
https://aws-observability.github.io/terraform-aws-observability-accelerator/
Apache License 2.0
288 stars 84 forks source link

[Bug]: Cannot convert the confmap.Conf: environment variable "1" has invalid name #279

Closed cloudchristina closed 2 months ago

cloudchristina commented 2 months ago

Welcome to the AWS Observability Accelerator

AWS Observability Accelerator Release version

v2.12.0

What is your environment, configuration and the example used?

Environment: EKS observability, EKS version 1.29. EKS ADOT Add-on version: v0.102.0

Configuration: using https://github.com/aws-observability/terraform-aws-observability-accelerator/blob/[…]ks-monitoring/otel-config/templates/opentelemetrycollector.yaml

Example used: https://aws-observability.github.io/terraform-aws-observability-accelerator/eks/

What did you do and What did you see instead?

I followed the instructions.

Errors: Error: failed to resolve config: cannot resolve the configuration: cannot convert the confmap.Conf: environment variable "1" has invalid name: must match regex ^[a-zA-Z_][a-zA- ││

image

Other:

I have tested with v0.104.0, v0.107.0, v0.108.0 all same errors

otel Chart.yml

apiVersion: v2
name: opentelemetry
description: A Helm chart to install otel operator
type: application
version: 0.8.0
appVersion: 0.108.0

Additional Information

Interesting things is I followed the instructions and deployed whole observability resources about 2 weeks ago and everything works fine.

akhilv-ciq commented 2 months ago

The issue is because of this line.

Please change replacement: $1 to replacement: $$1

subhashvizio commented 2 months ago

Ran into same issue. No more errors after replacing $$1 with $${1} and $$2 with $${2} AWS have to make this fix in their example. Until then have to download the module and make the changes locally.

bonclay7 commented 2 months ago

281 should address this