feat: enable polyglot otel config

aws-observability / terraform-aws-observability-accelerator

Open source project to help accelerate and ease observability setup on AWS environments

https://aws-observability.github.io/terraform-aws-observability-accelerator/

Apache License 2.0

288 stars 84 forks source link

feat: enable polyglot otel config #287

Closed hmuthusamy closed 3 weeks ago

hmuthusamy commented 4 weeks ago

What does this PR do?

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted. Consult the CONTRIBUTING guide for submitting pull-requests. Fix for nginx and java monitoring dashboards on EKS failing because of race condition deploying dashboards first before flux is deployed. Also added polyglot monitoring for Rust,.Net monitoring using OTEL.

Motivation

[ Yes] Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
[Yes ] Yes, I ran pre-commit run -a with this PR
[ Yes] Yes, I have added a new example under examples to support my PR (when applicable)
[ Yes] Yes, I have updated the Pages for this feature

Note: Not all the PRs required examples and docs.

For Moderators

[ ] E2E Test successfully complete before merge?

Additional Notes

hmuthusamy commented 3 weeks ago

Looks good but tests are failing. Can you run pre-commit and commit changes @hmuthusamy https://github.com/aws-observability/terraform-aws-observability-accelerator/actions/runs/11522847911/job/32088304356?pr=287

@bonclay7 Ran the pre-commit and submitted for review. Please review and merge. Thanks

elamaran11 commented 3 weeks ago

@hmuthusamy Precommit is failing still. Lets fix it.

hmuthusamy commented 3 weeks ago

Getting the below error on pr-commit. It runs fine when i ran the same PR locally.

Terraform docs...........................................................Failed

hook id: terraform_docs
files were modified by this hook

There are some problems with the CLI configuration: ╷ │ Error: The specified plugin cache dir /home/runner/work/terraform-aws-observability-accelerator/terraform-aws-observability-accelerator/.terraform.d/plugin-cache cannot be opened: stat /home/runner/work/terraform-aws-observability-accelerator/terraform-aws-observability-accelerator/.terraform.d/plugin-cache: no such file or directory │ ╵

As a result of the above problems, Terraform may not behave as intended.

bonclay7 commented 3 weeks ago

Fixed the tests, but I have one concern @hmuthusamy FYI - @lewinkedrs