search

aws-quickstart / quickstart-git2s3

AWS Quick Start Team
Apache License 2.0
170 stars 114 forks source link

Gitlab Project Id #36

Open josjaf opened 5 years ago

josjaf commented 5 years ago

Hi - I'm going through the web hook POST requests from Gitlab and I noticed we need a slight tweak.

The key event['body-json']['project_id'] exists in a push request, but not a merge request, so the lambda caught a KeyError with a merge. Below is my propose solution, let me know if you want a PR.

Thanks! 

#project_id = event['body-json']['project_id']
# project_id key works in push events, but not merge requests
project_id = event['body-json']['project']['id']
jaymccon commented 5 years ago

Thanks for reporting this @josjaf . A pr would be great. Just keep in mind that the ['body-json']['project_id'] is still valid in some cases, so it should not be commented out and rather use conditional logic or try->except.