search

aws-robotics / utils-common

ROS packages for facilitating the use of AWS cloud services.
Apache License 2.0
8 stars 20 forks source link

Update AWS SDK, fixed GCC 9 on ubuntu 20.04 #70

Closed fran6co closed 3 years ago

fran6co commented 4 years ago

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Fixes https://github.com/aws-robotics/utils-common/issues/55

fran6co commented 3 years ago

Not sure why the test is failing with a segmentation fault

dabonnie commented 3 years ago

FYI @emersonknapp @mm318.

I may be misremembering, but thought utils-common was stuck at 1.6 for Lex and Polly breaking changes. Thoughts on this PR?

mm318 commented 3 years ago

I do remember there needed to be code changes to the Lex Cloud Extension when updating between some AWS SDK versions, and I think we've already done that once before. It may apply to this new AWS SDK version bump as well.

These particular Build & Test failures are unrelated to breaking changes to downstream dependencies though. However, bumping the AWS SDK version should involve some testing of downstream dependencies though.

fran6co commented 3 years ago

The main reason I did this PR is for porting the ROS packages to 20.04 and noetic. I only had to fix this other project -> https://github.com/aws-robotics/utils-ros1/pull/36 for it to work

fran6co commented 3 years ago

Not sure why the test is failing with a segmentation fault

fixed segfault

jikawa-az commented 3 years ago

Following up on this, updated branch and retesting.

jikawa-az commented 3 years ago

@emersonknapp PTAL as well, this PR should add support for Focal which is not working for our images.