aws-samples / aws-get-started-workshop

Workshop to Get Started with AWS for Production Workloads
https://getstarted.awsworkshop.io
Other
64 stars 32 forks source link

update codebuild file #41

Closed cmbrehm closed 4 years ago

cmbrehm commented 4 years ago

This commit updates webspec.yml to

  1. Use latest release of hugo
  2. Install htmlproofer and use it to validate the HTML generated by hugo

If the validation detects any issues, it will now fail the build and not deploy out. As of this PR there are four external links that are not validating, I would be happy to chase those down and add the corrections to this PR if you want.

Alternatively we could ignore any errors from htmlproofer and deploy the artifacts by moving the deployment steps back to post_build as that stage is run whether the build stage succeeds or not.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

ckamps commented 4 years ago

You should update CONTRIBUTING.md with advice to usehtml-proofer locally for testing.