search

aws-samples / aws-secrets-manager-rotation-lambdas

Contains Lambda functions to be used for automatic rotation of secrets stored in AWS Secrets Manager
MIT No Attribution
330 stars 282 forks source link

Clarify expected behavior if test stage fails #71

Closed mdavis-xyz closed 1 year ago

mdavis-xyz commented 3 years ago

Please modify the docstring comment for the test_secret function.

What is my code supposed to do if the test fails? Do I return False, or throw an exception? If an exception, which exception?

whygoyal commented 2 years ago

Thank you for your feedback. We have noted this as a feature request.

jbct commented 1 year ago

Hi mdavis. We expect that there are exceptions raised for any errors encountered. Which particular exceptions are irrelevant to Secrets Manager - we're tracking that the testSecret step failed, the rest would show up in your CloudWatch logs for debugging.

mdavis-xyz commented 1 year ago

Ok, thanks for the explanation.

As someone in the target audience, that wasn't what I expected. So I've written a PR to clarify that.