search

aws-samples / lambda-refarch-imagerecognition

The Image Recognition and Processing Backend reference architecture demonstrates how to use AWS Step Functions to orchestrate a serverless processing workflow using AWS Lambda, Amazon S3, Amazon DynamoDB and Amazon Rekognition.
Apache License 2.0
665 stars 411 forks source link

cloudformation templates still ref node8 #25

Closed magic7s closed 4 years ago

magic7s commented 4 years ago

PR https://github.com/aws-samples/lambda-refarch-imagerecognition/pull/21 changed the runtime of lambda functions to node10 but did not update cloudformation template's s3 source files.

Execution of CFT per README.md at s3://media-sharing-refarch/cloudformation/image-processing-v3-node8.output.yaml builds node8 (actually fails on lambda function creation)

angelarw commented 4 years ago

thanks for calling it out. i will work on this asap

lijh-cn commented 4 years ago

I encounter this issue too. By replacing all the "nodejs8.10" by "nodejs12.x", the problem solved.

angelarw commented 4 years ago

i updated the template in the latest commit to master. let me know if it works for you now

lijh-cn commented 4 years ago

yes, it works. Thank you.

Angela Wang notifications@github.com 于2020年3月17日周二 上午9:49写道：

i updated the template in the latest commit to master. let me know if it works for you now

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/aws-samples/lambda-refarch-imagerecognition/issues/25#issuecomment-599836178, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE5NDXBMQVUJBHBLEDD2OKTRH3JKJANCNFSM4KWX3KDQ .